Skip to content

feat(advisory-review): share the PR review and test coverage checks - #31

Open
kdaula wants to merge 4 commits into
mainfrom
kavi/prt-723-review-bots
Open

kdaula wants to merge 4 commits into
mainfrom
kavi/prt-723-review-bots

Conversation

@kdaula

@kdaula kdaula commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Run the PR review and test coverage bots on actions

github-actions[bot]

This comment was marked as outdated.

bleggett
bleggett previously approved these changes Sep 24, 2026

@bleggett bleggett left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually make the PR review and test coverage checks shared actions in this repo, like the other shared actions we already have here, so that other repos do not need to copypaste the same .github workflows, and can just use a SHA ref to pull the action from this repo?

That makes keeping everything updated much simpler, since the check workflows live in a single spot.

@kdaula
kdaula force-pushed the kavi/prt-723-review-bots branch from d2670ad to 0c15ad1 Compare September 24, 2026 16:35
@kdaula kdaula changed the title feat(ci): add advisory PR review and test coverage checks feat(advisory-review): share the PR review and test coverage checks Sep 24, 2026
@kdaula

kdaula commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Added a commit that runs both checks on Opus 5.5 at max effort. The action moves to v1.0.236 (Claude Code 2.1.284) because the old pin predates Opus 5.5, and the review job timeout goes from 35 to 60 minutes since max effort makes each turn slower.

The naming test now allows the --model line, because a model ID always contains the vendor name. Any other mention still fails it.

@kdaula

kdaula commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@bleggett This PR now does that. Both checks live here as one reusable workflow, .github/workflows/advisory-review.yml, with the publisher, prompts and tests under advisory-review/. A repo pins it by commit and keeps a 48-line caller plus its own .github/review/focus.md and test-layers.md, which say what matters in that repo. The two repos that already had copies drop about 1,800 lines each in their migration PRs.

It is a reusable workflow rather than a composite action like the others here because each check runs as two jobs with different permissions. The job that runs the model gets a read-only token, and the job that posts the review runs no model. A composite action runs inside the caller's job with the caller's token, so every repo would have to set up that split itself.

@kdaula
kdaula requested a review from bleggett October 1, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants